Skip to content

docs: column-classification row filters on Trino and the attach notice (KI-287, KI-307) - #56

Merged
viethqb merged 1 commit into
mainfrom
docs/dg-p7-row-filter-notice
Nov 1, 2026
Merged

viethqb merged 1 commit into
mainfrom
docs/dg-p7-row-filter-notice

Conversation

@viethqb

@viethqb viethqb commented Nov 1, 2026

Copy link
Copy Markdown
Member

Docs for DG debt P7: platform #818 (merged, 10b0badf).

Known issues

  • Closed: KI-287 (on Trino a row filter by classification now filters every table where the classification is only on columns, with one row-filter policy per such table; both engines agree; Who can read? names the rule; the rule dialog no longer asks for Create anyway for it) and KI-307 (the attach answers notices with clearance_masks_pending_table, shown as a warning toast; masks still written once the table exists).
  • New: KI-333 (S2) a provisioned Trino engine with Per-user delegation → None gets no per-user baseline policies, so every query fails with Principal X cannot become user X. Confirmed in source: the baseline is seeded only when the engine delegates (supports_delegation()). S2, not S1, because the other three modes work.
  • New: KI-334 (S3) the Governance Data page's engine label can show a running engine as provisioning (it reads the stored engine status from the browse API); cosmetic, cause not confirmed.
  • Intro updated.

Pages

  • Masks and row filters: Row filters by classification rewritten (both engines; per-table Trino policy; boot recompile; tag-vs-resource precedence note); new Kind hint; KI-287 removed from limits.
  • Tagging: attach steps use the current labels (Add classification, Classification attached.) and describe the warning toast; limits updated.
  • Clearance, Explain access, Check access: KI-307 / KI-287 wording replaced; explain's Engine gaps section replaced by Row filters by classification; row_filter_not_applied noted as removed.
  • Provision: the None delegation mode links KI-333.
  • Upgrade: notes for #818 (behaviour change on Trino, new notices shape, removed fields).
  • REST reference regenerated from platform main's openapi.json; only control-plane-catalog (resource-tags notices) and perm (no trinoColumnOnly) are committed. workflow and the index count also differed and are left out. The explain page had no row_filter_not_applied row to remove.

The notice's wording for views is being changed in a separate platform PR, so the pages describe the behaviour and quote no sentence of it.

Not in this PR

  • Screenshots (Wave 4). No existing shot shows the changed UI. New shots worth taking: the rule dialog's Kind hint for a classification row filter, and the attach warning toast.

npm run build passes (en and vi).

🤖 Generated with Claude Code

…e (KI-287, KI-307)

Platform #818:
- close KI-287 (Trino filters tables where the classification is only on
  columns) and KI-307 (attach answers a clearance_masks_pending_table
  notice, shown as a warning toast); add KI-333 (open-mode Trino engine
  has no per-user baseline) and KI-334 (Data page shows a running engine
  as provisioning)
- masks and row filters, tagging, clearance, explain access, check access
  and provision pages; upgrade notes for #818
- regenerate the resource-tags and rule-effect REST pages

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@viethqb
viethqb merged commit 5e2fc4c into main Nov 1, 2026
2 checks passed
@viethqb
viethqb deleted the docs/dg-p7-row-filter-notice branch November 1, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant