Repository navigation
Import LoggingContext from where Synapse now defines it - #308
Merged
Merged
Conversation
Synapse 1.162.0 moved LoggingContext to synapse.synapse_rust.logcontext; synapse.logging.context no longer explicitly re-exports it, which strict mypy rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpxhUvvbRYpQSxhidPnnP7
devonh
marked this pull request as ready for review
October 9, 2026 18:23
This was referenced Oct 9, 2026
anoadragon453
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CI failures I am now seeing in the repo.
Synapse 1.162.0 moved
LoggingContexttosynapse.synapse_rust.logcontext. (element-hq/synapse#19979)synapse.logging.contextno longer explicitly re-exports it, which strict mypy rejects.The alternative to this PR is to re-export
LoggingContextin synapse fromsynapse.logging.context.But I think this is a minor change here and is only used in tests so nobody using the actual module will be affected.