Skip to content

Move V2 body assets out of the robot definition - #117

Merged
kou merged 4 commits into
enactic:mainfrom
stevenaya:refactor/v2-body-assets
Nov 4, 2026
Merged

kou merged 4 commits into
enactic:mainfrom
stevenaya:refactor/v2-body-assets

Conversation

@stevenaya

@stevenaya stevenaya commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • Move the V2 pedestal configuration and meshes to assets/body/v2.0/ and update preset/resource paths.
  • Generate body and reference-frame names from the instance prefix and local topology names, replacing root-name overrides.
  • Expose the arm mounting midpoint as arm_origin and number the pedestal visual parts, including scene-node IDs, vertex/normal/color source IDs and their references.

Validation

  • COLLADA IDs and references are checked for consistency; geometry, color and normal arrays compare exactly across the identifier cleanup.

  • 28 existing tests pass on ROS 2 Jazzy.

Review this change against main.

@stevenaya
stevenaya force-pushed the refactor/v2-body-assets branch from 0493cb0 to d7c2f79 Compare November 4, 2026 08:01
@stevenaya
stevenaya marked this pull request as ready for review November 4, 2026 08:02
Copilot AI balanced review requested due to automatic review settings November 4, 2026 08:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya
stevenaya force-pushed the refactor/v2-body-assets branch from d7c2f79 to 46af347 Compare November 4, 2026 09:15
Copilot AI balanced review requested due to automatic review settings November 4, 2026 09:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kou
kou merged commit 1329b1b into enactic:main Nov 4, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — 46af3478 Deployed Nov 4, 2026 by stevenaya via Publish #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants