Repository navigation
Simplify and split the V2 gripper camera visual - #121
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gripper camera visual still had small mounting-hole details and combined its base plate and lens in one geometry group. This update fills the small holes, simplifies the camera to 808 triangles, and splits it into PCB, base-plate and lens groups.
Changes
ee_base_link_03,ee_base_link_04andee_base_link_05consistently for the geometry groups and their COLLADA references.Visual comparison
Matched-camera renders of the PR base and head meshes. Opaque surfaces show the shape, with red triangle edges before and green edges after. Camera triangle count decreases by 54.0% and the complete DAE size by 2.8%.
Validation