Skip to content

Simplify and split the V2 gripper camera visual - #121

Merged
kou merged 1 commit into
enactic:mainfrom
stevenaya:codex/refine-v2-camera-visuals
Nov 4, 2026
Merged

kou merged 1 commit into
enactic:mainfrom
stevenaya:codex/refine-v2-camera-visuals

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

The gripper camera visual still had small mounting-hole details and combined its base plate and lens in one geometry group. This update fills the small holes, simplifies the camera to 808 triangles, and splits it into PCB, base-plate and lens groups.

Changes

  • Remove residual topology around the filled holes and reuse the reduced PCB, lens and four mounting pieces in the accepted camera geometry.
  • Use ee_base_link_03, ee_base_link_04 and ee_base_link_05 consistently for the geometry groups and their COLLADA references.
  • Reduce the base plate itself to 350 triangles. Its four mounting pieces add 182 triangles, the PCB has 46, and the lens has 230.
Mesh Before After
Camera 1,756 triangles 808 triangles
Complete gripper base 22,892 triangles 21,944 triangles
Gripper-base DAE 1,702,492 bytes 1,654,531 bytes

Visual comparison

Matched-camera renders of the PR base and head meshes. Opaque surfaces show the shape, with red triangle edges before and green edges after. Camera triangle count decreases by 54.0% and the complete DAE size by 2.8%.

View Before After
Lens side Lens side before Lens side after
Base-plate side Base-plate side before Base-plate side after

Validation

  • 28 existing tests pass on ROS 2 Jazzy.
  • COLLADA IDs are unique and internal references resolve. Camera solids pass closed-surface, winding and self-intersection checks.
  • The two camera installations match within 0.000038 mm after applying their assembly transform. Geometry and materials outside the camera compare exactly.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Copilot's per-file or total diff limits were exceeded. Try reducing the changed content or splitting the changes into smaller pull requests, then request a review from Copilot again.

@kou
kou merged commit 5238432 into enactic:main Nov 4, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — be55b5cb Deployed Nov 4, 2026 by stevenaya via Publish #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants