Skip to content

Preserve CAN launch overrides with preset-based descriptions - #103

Draft
stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:codex/preset-control-bringup
Draft

stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:codex/preset-control-bringup

Conversation

@stevenaya

@stevenaya stevenaya commented Nov 4, 2026 •

Copy link
Copy Markdown

CAN device selection remains configurable at launch while the selected description preset supplies the default hardware settings.

Depends on enactic/openarm_description#116 for V2 and enactic/openarm_description#119 for V1.

Changes

  • Pass robot_preset through bimanual bringup and MoveIt.
  • Keep left_can_interface, right_can_interface and can_fd as optional launch overrides. Empty arguments use the preset values, and explicit false selects CAN 2.0.
  • Apply overrides to the generated URDF's standard left/right ros2_control hardware systems and report a missing target system.
  • Give robot_state_publisher, controller_manager, MoveIt and RViz the same final robot description.

Validation

  • Existing launch checks cover V1/V2, mock/real hardware declarations, preset defaults and either side's override with CAN-FD disabled, across 24 configurations.
  • Model geometry and other hardware parameters compare exactly across overrides. Node-parameter checks confirm that every node receives the same final URDF.
  • Python syntax and autopep8 checks pass. The node-parameter check uses a stubbed MoveIt config builder; full MoveIt and hardware runs remain pending.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya
stevenaya force-pushed the codex/preset-control-bringup branch from 8f94672 to 03001e0 Compare November 5, 2026 06:10
Copilot AI balanced review requested due to automatic review settings November 5, 2026 06:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@stevenaya stevenaya changed the title Configure bimanual hardware through description presets Preserve CAN launch overrides with preset-based descriptions Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants