Repository navigation
Update gems with security advisories within current constraints - #38
Merged
Merged
Conversation
bundle update --conservative --minor for every gem bundle-audit flags that has a fix inside its current major version and the Gemfile's constraints. Clears 111 of 129 advisories. Rails, puma, sqlite3 and mail need a major bump or a Gemfile change and are left for PE-7185.
…atabase CI runs with a newer bundler-audit database than the local copy and flagged both. dalli 3.2.13 and faraday-http-cache 2.8.0 are the latest releases within their current majors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.
Updates the gems that
bundle auditflags and that can be fixed without a major version bump or a Gemfile change. OnlyGemfile.lockchanges.The updates ran with
bundle update --conservative --minor --strictso no other gem moved past what these required. datadog's native companion gems libdatadog (16 to 44) and libddwaf (1.22 to 1.30) follow datadog's own pins, and oauth2 2.0.25 brings in two small new dependencies, anonymous_loader and auth-sanitizer. rubocop stays at 1.70.0.This clears 119 of the 137 advisories in the current bundler-audit database. The remaining 18 are in Rails 7.0 (fixed in 7.1.5.2 and 7.2.3.1), Puma 5 (fixed in 7.2.1), sqlite3 1.x (fixed in 2.9.6) and mail, which the Gemfile pins to 2.7.x with a note that upgrading breaks
rails c. Those are tracked in PE-7185 and stay out of this change, so thebundle_auditCI job still fails.References
Risks
config/initializers/octokit.rbalready uses Marshal withshared_cache: false. The dalli socket patch inconfig/initializers/sockify.rbstill applies, becauselib/dalli/socket.rbis identical between 3.2.8 and 3.2.13.