Repository navigation
libmdbx: bump v0.14.3 -> v0.14.4 - #259
Merged
Merged
Conversation
Re-vendors the amalgamation via `make cp LIBMDBX_REF=v0.14.4`. Upstream "Skynet Eve" is a bugfix release of the stable branch; the public C API is unchanged (mdbx.h diff is documentation only), so the bindings need no adaptation. Notable upstream changes: - Windows: stricter checks for network, shared and layered volumes, to prevent database corruption and data loss. Placing a database on such a volume can now fail with MDBX_EREMOTE (ERROR_REMOTE_STORAGE_MEDIA_ERROR). - Fixed a missing sub-page header check in page_check(), which could SIGSEGV while checking a corrupted database. - Fixed a regression returning MDBX_BAD_TXN instead of MDBX_OUSTED. - Fixed division truncation in default_rp_augment_limit(), which yielded a too low and "stepwise" default MDBX_opt_rp_augment_limit. - Refined mdbx_get_sysraminfo(): sysinfo()/MemAvailable on Linux, host_statistics64() on macOS. Carries one local fix on top of v0.14.4: the new macOS path passes HOST_VM_INFO_COUNT (15) to host_statistics64(HOST_VM_INFO64), which wants HOST_VM_INFO64_COUNT (104) and fails with KERN_FAILURE otherwise, so mdbx_get_sysraminfo() returned MDBX_ENOSYS on every macOS build -- failing TestGetSysRamInfo and degrading libmdbx's own default dirty-page limit. The deviation is marked "mdbx-go local fix" in libmdbx/mdbx.c and is reported upstream; drop it once upstream takes it. Also notes in the README that a re-vendor wipes such local fixes, and that rebuilding after one needs `go build -a`: the mdbx package pulls libmdbx/mdbx.c in through a cgo #include across package directories, which the Go build cache does not track, so a plain `go test` happily re-runs the old C. `go test` and `go test -race` pass on darwin/arm64.
sudeepdino008
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-vendors the amalgamation via
make cp LIBMDBX_REF=v0.14.4. Upstream "Skynet Eve" is a bugfix release of the stable branch; the public C API is unchanged (themdbx.hdiff is documentation only), so the bindings need no adaptation.Notable upstream changes:
MDBX_EREMOTE(ERROR_REMOTE_STORAGE_MEDIA_ERROR) — upstream lists this as a backward-compatibility break.page_check(), which couldSIGSEGVwhile checking a corrupted database.MDBX_BAD_TXNinstead ofMDBX_OUSTED.default_rp_augment_limit(), which yielded a too low and "stepwise" defaultMDBX_opt_rp_augment_limit.mdbx_get_sysraminfo():sysinfo()+MemAvailableon Linux,host_statistics64()on macOS.One local fix on top of v0.14.4
The new macOS path passes
HOST_VM_INFO_COUNT(15) tohost_statistics64(HOST_VM_INFO64, ...), which wantsHOST_VM_INFO64_COUNT(104) and returnsKERN_FAILUREotherwise. So on a straight v0.14.4mdbx_get_sysraminfo()fails withMDBX_ENOSYSon every macOS build —TestGetSysRamInfofails, and libmdbx's owndefault_dp_limit()falls back to its worst-case estimate. One-token fix, markedmdbx-go local fixinlibmdbx/mdbx.c; drop it once upstream takes it.Re-vendor gotcha, now in the README
mdbxpulls inlibmdbx/mdbx.cthrough a cgo#includeacross package directories, which the Go build cache does not track — after a re-vendor a plaingo testhappily re-runs the old C. Rebuild withgo build -a. (Verified: with the macOS fix reverted,go test -count=1 ./mdbxstill passed.)go testandgo test -racepass on darwin/arm64;make toolsbuilds.