Skip to content

cam_hal: PSRAM JPEG: fall back to full-frame EOI search when the tail probe misses #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohannYellow wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

cam_hal: PSRAM JPEG: fall back to full-frame EOI search when the tail probe misses #871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions driver/cam_hal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,17 @@ camera_fb_t *cam_take(TickType_t timeout)
if (off >= 0) {
offset_e = dma_buffer->len - probe_len + off;
}
if (offset_e < 0) {
/* Fallback for sensors that pad the frame past the EOI. The OV3660 appends
* ~2.2-2.9 kB of zeros after the end marker, so it lands outside the narrow
* tail probe above and every frame would be discarded as NO-EOI. Re-scan the
* whole frame with the same backward search the non-PSRAM path uses; the last
* marker before the zero padding is the real EOI. Safe against the stale-frame
* case the probe window guards: len = cnt * dma_half_buffer_size, so all of
* [0, len) was written by THIS frame's DMA - stale bytes only live beyond len. */
cam_drop_psram_cache(dma_buffer->buf, dma_buffer->len);
offset_e = cam_verify_jpeg_eoi(dma_buffer->buf, dma_buffer->len, false);
}
} else {
offset_e = cam_verify_jpeg_eoi(dma_buffer->buf, dma_buffer->len, false);
}
Expand Down