Repository navigation
Conversation
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
pnpm exec changesetto create a changeset. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | koala#18895 |
searchEventsorder fix: koala#18934 | schema from openapi#494 @78d51f2Why
Check that regenerating from
fingerprint-server-api-v4-flat.yaml(whereEventis one object again) does not break Python users.Things to note
Eventsplit. Going from the publishedv4.yamlto the flat schema changes only theEventdocstring (event.py,docs/Event.md).sourcestaysOptional[EventSource] = None, no new models or enums, same fields,from_dict/to_dictand__init__untouched. At schema level,Eventequals the published one exceptdescription, and the only other change inres/isEnvironmentIdmoving earlier. Example files are byte-identical to the published ones.search_events(and_with_http_info,_without_preload_content) now takeactive_callbeforesource, because the published schema lists them in that order. The methods have no*, so only callers passing 50+ arguments positionally would be affected (keyword calls, README andexamples/are fine). It breakstest_search_events_all_params, which hardcodes the old query-string order; fixed in the last commit. koala#18934 fixes the order in koala's schema, so a real sync after it lands won't swap them.sourceand an edge event (source: edge, noidentification).Change outline
Commits:
Generated
Eventchange (commit 2 vs 1), docstring only:class Event(BaseModel): """ - Contains results from Fingerprint Identification and all active Smart Signals. Some Smart Signals ... + Contains results from Fingerprint Identification and all active Smart Signals, or from the Automation Intelligence API. Check `source` to see which properties can be present: - `device` - ... - `edge` - ... Events stored before `source` was added don't have it; treat them as `device`. ... """Baseline drift (commit 1 vs
main),search_eventssignature (fixed in koala#18934):New tests (
test/test_event_source.py):Files: