Repository navigation
Conversation
Secondary tags have no stored order: they are listed by name, and the tag order only carries primary tags and their children. Dragging one within its list sent an order request without it and snapped back. Sorting within the secondary list is now off; tags can still be dragged between the primary and secondary lists. Fixes #5236
Saving an existing tag from the edit modal sent isPrimary: false, as the modal only knows the kind of a tag it creates. That cleared the flag on primary tags while their position stayed, so the API and the MCP tag list reported them as secondary. - The modal now sends isPrimary only when creating a tag. - The API refuses a change to isPrimary on update with a 422; sending it back unchanged still saves. A tag changes kind through the tag order, which also sets its position. - A migration sets is_primary from position again, and renumbers positions within each list where tags created meanwhile share one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5236
Changes proposed in this pull request:
Stop offering reordering within the alphabetical secondary-tag list while keeping moves between primary and secondary tags. Editing a tag now preserves its kind; changing
isPrimaryalone returns 422, while an unchanged value remains accepted. An upgrade migration repairs incorrect flags and duplicate positions.Reviewers should focus on:
Screenshot
Before: dragging Charlie temporarily changes the secondary list, then the order is discarded.
After: the secondary list stays alphabetical during the same drag.
Before recording · After recording
Necessity
Confirmed
yarn testinjs/).composer test).Required changes: