Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested on Discuss: https://discuss.flarum.org/d/40038-introducing-deck-follow-every-conversation-you-care-about-live/4 (no issue)
Changes proposed in this pull request:
Adds a
group:filter for discussions:group:modslists the discussions started by a member of Mods. Groups can be named by ID, singular or plural name in any case, a comma list matches any of them, and-group:excludes them. The existingGroupGambitis now registered for discussions too, so the forum search and Deck's custom filter columns accept it, e.g.group:mods is:unread -author:me.Until now
group:only existed for users; in a discussion search it fell through to a text search for the words "group" and the group's name.Reviewers should focus on:
group:membersmatches every registered author, as Deck's postsauthorGroupfilter does;-group:includes discussions whose author was deleted.lower(), which only folds ASCII on SQLite.GlobalSearchStateno longer writes a filter twice now that discussions and users share a gambit (filter[group]=modsbecamegroup:mods group:mods).Screenshot
The search window's suggestions now offer
group:for discussions.Necessity
Confirmed
yarn testinjs/).composer test).Required changes: