Repository navigation
test(docker): the delete tests ask a fixture upstream, not Docker Hub - #1179
Merged
Merged
Conversation
Both delete tests set the binary's default upstream to give a pushed name its namespace, and so asked Docker Hub for the deleted manifest. Docker Hub answers 401 for a name it does not hold, which is a 404 here; when it answered 5xx or not at all, the miss was a 502 and the test failed, though the manifest was gone. The default upstream keeps its namespace and points at a local fixture that answers 404 to everything. With no network the tests pass, in about a second instead of fourteen; with the fixture answering 503 both see 502, so the miss does reach it.
ertime037
approved these changes
Oct 26, 2026
ertime037
enabled auto-merge
October 26, 2026 19:55
|
🐳 Test image pushed: docker pull ghcr.io/getnora-io/nora:pr-1179
docker run --rm -p 4000:4000 ghcr.io/getnora-io/nora:pr-1179 |
ertime037
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
a_deleted_manifest_is_gone_on_local_and_object_storageanda_delete_removes_both_copies_of_a_manifestuse the binary's default Docker upstream, so that a pushed name gets the upstream's namespace and a delete has two keys. After the delete, the GET for the manifest was a miss asked of Docker Hub. Docker Hub answers 401 for a name it does not hold, which NORA turns into 404; when it answered 5xx or not at all, the miss was 502 and the tests failed although the manifest was gone. That happened in the coverage job of the merge group for #1178.After
The default upstream keeps its namespace and points at a local fixture that answers 404 to every request. The layout under test is unchanged; no request leaves the machine.
How it was checked
502instead of404; with network they passed in 13.9 s.502— the miss does reach the fixture.cargo fmt --check,cargo clippy --all-targets -D warnings, theregistry::dockertests.