Repository navigation
docs(storage): a GCS emulator needs a disable_oauth key file; fake-gcs-server is not one - #1187
Merged
Merged
Conversation
…s-server is not one The GCS doc comments named fake-gcs-server as a supported emulator. It is not: it has no XML API object PUT and does not handle x-goog-copy-source, so NORA cannot write to it on any version. They also implied an http:// base_url is enough. It skips request signing, but object_store's GCS client still asks the credential provider for a token on writes, so without key material every PUT fails with "Error getting token response body". A service-account file with "disable_oauth": true (private_key, private_key_id and client_email present but unused) makes writes work against an XML API emulator.
|
🐳 Test image pushed: docker pull ghcr.io/getnora-io/nora:pr-1187
docker run --rm -p 4000:4000 ghcr.io/getnora-io/nora:pr-1187 |
ertime037
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCS doc comments (
storage/object.rs,config/storage.rs) named fake-gcs-server as a supported emulator and implied that anhttp://base URL is enough. Neither is true:uploadType) and does not handlex-goog-copy-source, so NORA can't write to it on any version.http://base URL skips request signing, but object_store's GCS client still asks the credential provider for a token on writes. Without key material every PUT fails withError getting token response body.What works against an XML API emulator is a service-account file with
"disable_oauth": true.private_key,private_key_idandclient_emailmust be present but are not used. object_store's own example leaves outprivate_key_id, and NORA then fails at startup withmissing field private_key_id. We checked on 1.4.3 and with object_store 0.14 (#1162): with this file, small and multipart writes and reads work; without it, writes return 500.Only comments change, no behaviour.