Skip to content

fix(seer): Set viewer context for missing issue-assignment paths - #127873

Merged
sehr-m merged 1 commit into
masterfrom
fix/seer-viewer-context-metric-sampling
Oct 16, 2026
Merged

sehr-m merged 1 commit into
masterfrom
fix/seer-viewer-context-metric-sampling

Conversation

@sehr-m

@sehr-m sehr-m commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

This PR fixes only the issue-assignment paths that can reach the first-assignment Seer summary without ViewerContext. There is no higher up place that we could assign ViewerContext where we have a valid User and we would need to default to System which is incorrect

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2026
@sehr-m
sehr-m force-pushed the fix/seer-viewer-context-metric-sampling branch from 3395296 to d8e3766 Compare October 16, 2026 21:11
@sehr-m sehr-m changed the title fix(seer): Record viewer context failures without sampling fix(seer): Preserve first-assignment viewer attribution Oct 16, 2026
@sehr-m
sehr-m force-pushed the fix/seer-viewer-context-metric-sampling branch from d8e3766 to 24bbc9b Compare October 16, 2026 21:36
@sehr-m sehr-m changed the title fix(seer): Preserve first-assignment viewer attribution fix(seer): Set viewer context at issue assignment boundaries Oct 16, 2026
@sehr-m
sehr-m force-pushed the fix/seer-viewer-context-metric-sampling branch from 24bbc9b to 6a27cd4 Compare October 16, 2026 21:48
@sehr-m sehr-m changed the title fix(seer): Set viewer context at issue assignment boundaries fix(seer): Set viewer context for missing issue-assignment paths Oct 16, 2026
@sehr-m
sehr-m force-pushed the fix/seer-viewer-context-metric-sampling branch 2 times, most recently from 71fbe53 to b9f518f Compare October 16, 2026 22:20
@sehr-m
sehr-m force-pushed the fix/seer-viewer-context-metric-sampling branch from b9f518f to 2a454b0 Compare October 16, 2026 22:27
@sehr-m
sehr-m marked this pull request as ready for review October 16, 2026 22:29
@sehr-m
sehr-m requested review from a team as code owners October 16, 2026 22:29
@sehr-m
sehr-m merged commit 624fb34 into master Oct 16, 2026
88 checks passed
@sehr-m
sehr-m deleted the fix/seer-viewer-context-metric-sampling branch October 16, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants