Repository navigation
Conversation
Author
|
Closing, since this repository has not had any commits since mid-2024. Happy to reopen if it becomes active again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
Route.Queriesreceives an odd number of parameters, it previously setr.errand returnednil. Because callers use fluent builder chaining on*Route(such asr.Queries(...).Path(...).Handler(...)or checkingr.Queries(...).GetError()), returningnilcaused an immediate nil pointer dereference instead of preserving the error on the route.This change:
Route.Queriesto returnrwhen parameter validation fails, consistent withHeaders,HeadersRegexp, and other route builder methods.Querieswithif r.err == nilso pre-existing route errors are preserved without attempting redundant regexp additions.