Repository navigation
Conversation
UIStorage.export() already blanked the Visualizer username and password (graphefruit#520), but the cloud AI API key and the brew-by-weight webhook bearer token, basic auth credentials and custom header value were still written into manual exports and the automatic backup ZIPs. Blank all of them in one place and cover it with unit tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UIStorage.export()already blanks the Visualizer username and password before writing an export (#520), but other credentials stored in settings were still written into manual exports and the automatic backup ZIPs:cloud_ai_api_key, the AI provider key for bean import (added in c1f8580)brew_by_weight_webhook.bearerToken,basicUsername,basicPasswordandcustomHeaderValue(added in 80d7184)Backups are often shared, for example attached to a support request or moved to another device, so these keys could leave the device without the user knowing.
This PR blanks all of them in one place (
UIStorage.removeCredentialsFromSettings), next to the existing Visualizer handling. Everything else in settings, including the webhook URL and the AI model, stays in the export. As with the Visualizer credentials today, after importing a backup the user re-enters these keys.GitHub Issue / Discussion Reference
Ref: #520 (same handling for the Visualizer credentials)
AI Assistance Disclosure
AI Usage Level
AI Provider / Tool
Type of Change
Screenshots / Videos (if applicable)
No UI change. New unit tests in
src/services/__tests__/uiStorage-export.spec.ts:brew_by_weight_webhookexport fineThe credential tests fail on
developand pass with this change. The full suite is 691 tests. 2UnwrappedServicefrozen-bean tests fail, and they fail ondeveloptoo.Tested Platforms
Checklist