Repository navigation
feat: add --sort flag to order output by filename and line number - #48
Merged
Merged
Conversation
Add a new `--sort` (`-s`) flag that sorts the output by filename and line number. This makes the output more deterministic and easier to compare between runs, especially useful when integrating with diff tools. Changes: - Add `flagSortOutput` global variable - Add `SortOutput` field to SQLVet struct - Update `NewSQLVet` to accept sortOutput parameter - Add sorting logic in `Vet()` method using sort.Slice - Add `--sort` flag definition in rootCmd Closes houqp#25
Collaborator
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #25 by adding a
--sort(-s) flag that sorts the output by filename and line number.Motivation
When comparing output between different runs (e.g., using diff), the non-deterministic order of results can make comparisons noisy. Sorting the output makes it more deterministic and easier to work with.
Changes
flagSortOutputglobal variableSortOutputfield toSQLVetstructNewSQLVetto acceptsortOutputparameterVet()method usingsort.Slice--sort(-s) flag definition inrootCmdUsage
Testing
The changes are minimal and non-breaking:
--sortflag is usedsort.Slicefor stabilityCloses #25