Repository navigation
Move the Peppol BIS UBL and CII formats into gobl.peppol and import endpoints - #10
Merged
Merged
Conversation
… (MAP-19) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
migueltorresvalls
requested review from
alvarolivie
and
a lite review from Copilot
November 17, 2026 14:43
…e PINT sg-invoice fixture (MAP-19) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…(MAP-19) gobl.cii no longer registers its own Peppol format, so FormatBIS is registered from this package's init and detected documents run importEndpoints. Pins gobl.cii to the pre-release commit that drops its Peppol format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Peppol invoices don't carry EM addresses, so the EAS scheme is always mapped to iso6523-actorid-upis::<scheme>:<code>, without a mailto special case. The UBL helper is renamed importPartyEndpoint to match CII. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alvarolivie
approved these changes
Nov 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
miguelalvarezd
added a commit
that referenced
this pull request
Nov 19, 2026
Brings in the Peppol BIS formats and the endpoint import (#10). FormatAE now imports endpoints with the shared importEndpoints, so it keeps the inbox gobl.ubl adds next to the endpoint, as PINT and A-NZ do, and drops its own importAEPartyEndpoint. The BIS, PINT and A-NZ fixtures are main's, so this PR only changes the AE ones. gobl.ubl is pinned to #189 rebased on its main, which has #193. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAP-19: gobl.peppol now owns the Peppol BIS UBL and CII formats (moved out of gobl.ubl in invopop/gobl.ubl#193 and gobl.cii in invopop/gobl.cii#145), and Peppol imports add the seller's (BT-34) and buyer's (BT-49) electronic address as a GOBL endpoint for any EAS scheme, since these documents always arrive through Peppol.
Changes:
FormatBISin theublinit (alongside PINT and A-NZ) and in theciiinitFormatBISandSpecificationBISSelfBillinguse thepeppol-bis-v3addon (which requireseu-en16931-v2017) instead of EN 16931 aloneimportEndpointsin the UBL (BIS, PINT, A-NZ) and CII (BIS) import funcs:iso6523-actorid-upis::<scheme>:<code>; skipped for an empty scheme or when the party already has an endpoint of that kind; base inboxes are keptpeppol-bis-v3(two got a synthetic PO reference for R003); portinvoice-dk-domestic-transferfrom gobl.ubl; drop the loose PINTsg-invoiceparse fixture; regenerate goldensNotes:
FormatBISstill declares only EN 16931; follow-up.ubl.ExportbeforeexportBISBillingjoins them; follow-up to merge notes in the addon.🤖 Generated with Claude Code