Skip to content

Move the Peppol BIS UBL and CII formats into gobl.peppol and import endpoints - #10

Merged
migueltorresvalls merged 6 commits into
mainfrom
normalize-peppol-inboxes
Nov 19, 2026
Merged

migueltorresvalls merged 6 commits into
mainfrom
normalize-peppol-inboxes

Conversation

@migueltorresvalls

@migueltorresvalls migueltorresvalls commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

MAP-19: gobl.peppol now owns the Peppol BIS UBL and CII formats (moved out of gobl.ubl in invopop/gobl.ubl#193 and gobl.cii in invopop/gobl.cii#145), and Peppol imports add the seller's (BT-34) and buyer's (BT-49) electronic address as a GOBL endpoint for any EAS scheme, since these documents always arrive through Peppol.

Changes:

  • Register FormatBIS in the ubl init (alongside PINT and A-NZ) and in the cii init
  • UBL FormatBIS and SpecificationBISSelfBilling use the peppol-bis-v3 addon (which requires eu-en16931-v2017) instead of EN 16931 alone
  • importEndpoints in the UBL (BIS, PINT, A-NZ) and CII (BIS) import funcs: iso6523-actorid-upis::<scheme>:<code>; skipped for an empty scheme or when the party already has an endpoint of that kind; base inboxes are kept
  • Test data: BIS convert inputs declare peppol-bis-v3 (two got a synthetic PO reference for R003); port invoice-dk-domestic-transfer from gobl.ubl; drop the loose PINT sg-invoice parse fixture; regenerate goldens

Notes:

🤖 Generated with Claude Code

… (MAP-19)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@migueltorresvalls
migueltorresvalls requested review from alvarolivie and a lite review from Copilot November 17, 2026 14:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

…e PINT sg-invoice fixture (MAP-19)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 17, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

…(MAP-19)

gobl.cii no longer registers its own Peppol format, so FormatBIS is registered from this package's init and detected documents run importEndpoints. Pins gobl.cii to the pre-release commit that drops its Peppol format.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 18, 2026 11:49
@migueltorresvalls migueltorresvalls changed the title Own the Peppol BIS UBL format and add BT-34/BT-49 endpoints on import Move the Peppol BIS UBL and CII formats into gobl.peppol and import endpoints Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Peppol invoices don't carry EM addresses, so the EAS scheme is always mapped to iso6523-actorid-upis::<scheme>:<code>, without a mailto special case. The UBL helper is renamed importPartyEndpoint to match CII.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 19, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 19, 2026 14:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 19, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@migueltorresvalls
migueltorresvalls merged commit 75663c6 into main Nov 19, 2026
4 checks passed
miguelalvarezd added a commit that referenced this pull request Nov 19, 2026
Brings in the Peppol BIS formats and the endpoint import (#10). FormatAE
now imports endpoints with the shared importEndpoints, so it keeps the
inbox gobl.ubl adds next to the endpoint, as PINT and A-NZ do, and drops
its own importAEPartyEndpoint. The BIS, PINT and A-NZ fixtures are main's,
so this PR only changes the AE ones. gobl.ubl is pinned to #189 rebased on
its main, which has #193.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants