Repository navigation
net: bind verifications and registrations to the subject's address and key; verified senders only #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samlown
wants to merge
21
commits into
main
Choose a base branch
from
net-verifier-audience
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
net: bind verifications and registrations to the subject's address and key; verified senders only #1036
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
381ae63
net: bind verifications to an address, require iat, bound key fetches
samlown 5bfe840
net: cap authority countersignatures at 90 days
samlown 19efe34
net: bind registrations and verifications to the subject's key
samlown 2cdeefb
net: FindVerification takes the subject
samlown f6c65ca
net: spell out and cite ACME, RFC 7638 and RFC 7800
samlown 62e54e6
net: require cnf on verifier countersignatures
samlown e7b0f9e
net: authorities register only verified parties; trust verifiers dire…
samlown 1c46ab6
net: FindVerifications returns every valid verification
samlown 2994b8d
net: address Copilot review comments
samlown 700b886
net: cover dialing, FindVerifications inputs and unsigned pairs
samlown 7f4fd5d
net: rewrite the spec for readability
samlown 7b7e9f0
net: address further review comments
samlown 1ffe994
net: refuse every special-purpose range that is not globally reachable
samlown d273609
net: bind key changes to the new key, and follow no redirects
samlown 9a9b755
net: simplify key lineage and add SignKeyChange
samlown d63d22a
net: reject envelopes whose document does not match its digest
samlown 9fde915
net: document signature bindings and add a tampering suite
samlown a31effb
net: reject envelopes with no document, and tamper with dig
samlown 4080ac9
net: add key changes to the bindings table
samlown b23083b
net: fold the digest check changelog into net-verifier-audience
samlown 6655883
net: fix review findings on endorsements, confirmations and dialing
samlown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## Changed | ||
|
|
||
| - `net`: **breaking**: verifier countersignatures count only when their `aud` is the envelope's `from` address, so each address needs its own verification, and they need a `cnf` naming the subject key the verifier saw. | ||
| - `net`: **breaking**: authority countersignatures need an `iat` no later than the present and an `exp` at most 90 days after it. | ||
| - `net`: **breaking**: `Client.VerifyDelivery` and `Client.Who` need an `iat` no later than the present, and a key that is still valid when the envelope is received. | ||
| - `net`: **breaking**: authority countersignatures need a `cnf` naming the key of a signature that confirms the envelope's `from` and `to`; `Endorsement.Key` reports it. | ||
| - `net`: **breaking**: `Client.VerifySender(ctx, env, requireVerified)` takes a delivered envelope, and requires it to be signed with the sender's registered key. | ||
| - `net`: `Client.DeliveryKeys` returns the keys confirming a delivery, and `Client.FindVerification` reads a verifier countersignature, for authorities tracking key lineage. | ||
| - `head`: `WithConfirmation` sets an RFC 7800 `cnf` claim, read from `SigningPayload.Confirmation`. | ||
| - `dsig`: `JKT` returns a key's RFC 7638 thumbprint in base64url form. | ||
| - `net`: only the first four signatures by one issuer are checked against its keys. | ||
|
|
||
| ## Fixed | ||
|
|
||
| - `net`: `HTTPFetcher` dials the addresses it has checked, rather than resolving the host again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.