Skip to content

Add a third street line to addresses - #1039

Closed
miguelalvarezd wants to merge 2 commits into
mainfrom
address-street-third
Closed

miguelalvarezd wants to merge 2 commits into
mainfrom
address-street-third

Conversation

@miguelalvarezd

@miguelalvarezd miguelalvarezd commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Closed: no longer required

  • org: street_third on addresses, for the third address line of EN 16931 (BT-162 seller, BT-163 buyer, BT-164 tax representative, BT-165 delivery), with Address.LineThree() to read it, as LineOne() and LineTwo() do. org.Address only had street and street_extra, so the third line was lost in conversion.

UBL writes it as cac:AddressLine/cbc:Line. invopop/gobl.ubl#192 writes and reads it there, for every party and the delivery location, and invopop/gobl.ubl#189 for a bank account's branch. PINT AE uses the same terms. invopop/gobl#1040 and, on top of it, invopop/gobl#1033 are stacked on this PR, so that gobl.peppol#8 can pin one commit with all three; neither uses street_third.

No GOBL example added: no example uses street_extra either, and the field is exercised in gobl.ubl#192's conversion tests.

Pre-Review Checklist

  • Opened this PR as a draft
  • Read the CONTRIBUTING.md guide.
  • Performed a self-review of my code.
  • Added thorough tests with at least 90% code coverage.
  • Modified or created example GOBL documents to show my changes in use, if appropriate.
  • Added links to the source of the changes in tax regimes or addons, either structured or in the comments.
  • Run go generate . to ensure that the Schemas and Regime data are up to date.
  • Reviewed and fixed all linter warnings.
  • Been obsessive with pointer nil checks to avoid panics.
  • Added a file to changes/unreleased with an overview of my changes, as described in changes/README.md.
  • Marked this PR as ready for review.

And if you are part of the org:

  • Requested a review from Copilot and fixed or dismissed (with a reason) all the feedback raised.
  • Requested a review from @samlown.

🤖 Generated with Claude Code

EN 16931 addresses have three lines (BT-162, BT-163, BT-164, BT-165),
but org.Address only had street and street_extra, so the third was lost
in conversion. street_third holds it, with Address.LineThree() to read
it as LineOne() and LineTwo() do.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (0487f2f) to head (8fcde49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         336      336           
  Lines       15422    15424    +2     
=======================================
+ Hits        14949    14951    +2     
  Misses        472      472           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the supplied changes cover the third address line across the model, normalization, schema, tests, and changelog.

No open issues 🎉

What changed in this PR

Adds support for a third street-address line in org.Address, preserving address data required by EN 16931 and enabling downstream format conversions.

Changes:

  • Adds the street_third field and LineThree() accessor.
  • Normalizes the new field alongside existing address components.
  • Updates the generated schema, tests, and unreleased changelog entry.
File Description
org/​address.go Defines, exposes, and normalizes the third street line.
org/​address_test.go Tests normalization and LineThree() behavior.
data/​schemas/​org/​address.json Exposes street_third in the address schema.
changes/​unreleased/​address-street-third.md Documents the new address capability.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants