Repository navigation
Conversation
Add a `tabTap` config option that scrolls the content of a tab to the top when its already selected tab button is pressed. The content only scrolls when the tab is at its root page. If the tab is on a child page, the existing behavior is kept. Supported in ion-tabs, Angular, React, and Vue. References ionic-team#22558
|
@DwieDima is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
package: core
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #22558
What is the current behavior?
Pressing the already selected tab button does not scroll the content of the tab to the top. Apps have to write their own click listeners to do this.
What is the new behavior?
tabTapoption toIonicConfig, similar tostatusTap. It defaults tofalse.tabTapis enabled and the already selected tab button is pressed while the tab is at its root page, the content of the tab scrolls to the top.ion-tabsdoes nothing.ion-tabs(including anion-navinside a tab),@ionic/angular,@ionic/reactand@ionic/vue. Each framework reuses its existing check for whether the tab is at its root.Does this introduce a breaking change?
Other information
The
tabTapoption still needs to be documented in theionic-docsrepo.