Repository navigation
DS100: read line voltages and per-phase frequency - #3
Merged
Merged
Conversation
- restore Voltage at 0x040C (average L-N). Renaming it to VoltageL_N_avg left Voltage without an opcode, so Probe and Produce read register 0 - keep Current at 0x0418 (three phase vector current). 0x0416 is the neutral current, not the total - read the new L-L voltages, average L-L voltage and per-phase frequencies in Produce. Opcodes alone are never queried - drop the commented-out THD registers, which are not in the manual Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3FK111BpSpYmto2BsT3Ea
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3FK111BpSpYmto2BsT3Ea
isarrider
force-pushed
the
fix/ds100-opcodes
branch
from
October 19, 2026 15:03
80f6f7d to
41d83be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for upstream volkszaehler#385 (its head is this fork's
master).Register addresses are checked against the B+G e-tech DS100 manual.
Voltagehad no opcode. The PR renamedVoltage: 0x040CtoVoltageL_N_avg, butProbe()andProduce()still readVoltage. A missing map entry yields opcode0x0000, so device detection and the average voltage read the wrong register. This restoresVoltage: 0x040C(average L-N).Currentstays at0x0418. The PR moved it to0x0416, which the manual lists as the neutral current.0x0418is the three-phase vector current, as before.Produce()are never queried. This adds the L-L voltages, the average L-L voltage and the per-phase frequencies (7 more register reads).The diff against upstream
masteris now limited to these additions.Generated by Claude Code