Repository navigation
Kaui 10.21 - #671
Merged
Merged
Kaui 10.21#671
Conversation
Clicking a saved advanced search navigated to ?_q=1&name[like]=..., a URL only the payments/invoices pages understood, so the accounts list showed every account. Saved searches now use ?advance_search_query=<encoded>, the same URL the Apply button builds. Also stop ERB from HTML-escaping the server-rendered advance_search_query on the accounts page: '&' became '&' and Kill Bill rejected the search with a SQL syntax error on page load. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
getUrlParams() decoded advance_search_query twice: URLSearchParams.get() already decodes it, and decodeURIComponent was then applied to values such as '%test%', which throws "URI malformed". The exception was raised from the table's draw.dt handler (populateSearchLabelsFromUrl), so DataTables never hid its processing indicator and the filter pill was never rendered. Only decode when the query comes from the raw location.search, and fall back to the raw string if decoding fails. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Ruby version to work with Latest ubuntu 26.04