Repository navigation
feat(config): add reclaimed CPU PSI eviction settings - #238
Closed
cheney-lin wants to merge 1 commit into
Closed
cheney-lin wants to merge 1 commit into
cheney-lin wants to merge 1 commit into
Conversation
Add optional AQC controls for sustained reclaimed cgroup CPU PSI pressure, including taint, soft eviction, dwell times and proposal budgets. Preserve omitted versus explicit false/zero fields and generate the CRD and deepcopy. Assisted-by: Codex:gpt-6-astra Co-authored-by: Codex <noreply@openai.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding reclaimed CPU PSI eviction settings to the configuration API. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
Adds optional
spec.config.evictionConfig.beCPUPSIEvictionConfigsettings for sustained reclaimed-cgroup CPU PSI full pressure: independent sampling, taint and soft-eviction switches; observation and dwell intervals; pressure/recovery thresholds; external-usage and idle gates; cooldown, proposal budget and grace period.All fields are pointers so omission preserves agent defaults and explicit false/zero values survive configuration delivery. Numeric ranges are included in the generated CRD. Cross-field ordering and eviction-requires-taint validation belong to the consuming agent. This API change alone does not enable eviction.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Regenerated the AdminQoSConfiguration CRD with controller-gen v0.15.0 and config deepcopy with the repository-pinned k8s.io/code-generator v0.24.6. The generated deepcopy diff also normalizes existing function ordering and an equivalent slice copy.
Validation:
go test -gcflags=all=-l -race ./pkg/apis/config/v1alpha1passed with Go 1.26.5. The new test verifies JSON round trips, nil/false/zero preservation and non-aliasing for every pointer field. Generated outputs and git diff whitespace checks passed.Consumers must upgrade the API module and installed CRD before using the new field.
I can’t confirm details such as generated CRD changes or test results from the supplied change summary alone.