Repository navigation
Conversation
tamird
force-pushed
the
type-watch-stream-events
branch
6 times, most recently
from
June 20, 2026 11:39
ca757ba to
98cdb8f
Compare
tamird
marked this pull request as draft
June 20, 2026 15:54
tamird
force-pushed
the
type-watch-stream-events
branch
from
June 20, 2026 18:54
98cdb8f to
b0d8253
Compare
tamird
marked this pull request as ready for review
June 20, 2026 18:59
tamird
marked this pull request as draft
June 20, 2026 20:05
tamird
marked this pull request as ready for review
June 20, 2026 22:10
tamird
force-pushed
the
type-watch-stream-events
branch
6 times, most recently
from
June 21, 2026 01:11
32cbc48 to
cb838d7
Compare
Author
|
@lexdene my codex went a little further than expected here, but I did have it split the changes into multiple commits in case you wanted to merge without squashing or if you want, I am happy to send multiple PRs. Please let me know, and thanks for maintaining this project! |
Owner
|
This PR is too large for me to review thoroughly. |
Type kubernetes.watch events using the watched list method or an explicit model class. Preserve bookmark, raw, log, and argument-forwarding behavior in focused type-checker coverage. Anchor the generated-package ignore rule so the new watch stub sources are included in the built distribution.
tamird
force-pushed
the
type-watch-stream-events
branch
from
July 22, 2026 20:25
cb838d7 to
d7ddc2d
Compare
Author
|
I am just going to fix upstream kubernetes client to have proper types. Thanks! Follow along in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubernetes-stubsis partial, so an omitted module or member fallsback to the runtime package. The runtime is mostly unannotated, so
Watch streams, quantity helpers, and the ApiClient stored by generated
API classes become
Any.Describe
Watch.streamin terms of the watched callable's list itemtype or the class literal passed to
Watch. Preserve the callable'sarguments with
ParamSpec. Model bookmark and invalid-line resultsexplicitly. Calls that set
deserializeand non-list methods remainobject: the runtime consumes that keyword itself and uses docstrings,not the callable's return annotation, to distinguish log streams.
Mirror the runtime's package-shaped
kubernetes.watchandkubernetes.utilsmodules. Add the public quantity and ApiClientinterfaces, generate
api_clienton each API class, and retain thehandwritten client exports when the generator writes its final
__all__.Use uv for code generation, wheel builds, and checker dependencies so
local checks and release workflows share one locked environment. The
pull-request check builds and installs a Kubernetes 36.0.2 wheel,
removes the generated source tree, and exercises the public types with
mypy, Pyright, and ty.
Ty currently leaves the generic protocol specialization as
Unknown.The three affected assertions stay enforced by mypy and Pyright; ty
uses scoped suppressions and will report them as unused when its
constraint solver supports this case.