Repository navigation
reject join.across and join.shim for animated joins - #4634
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrupt animation when join.animated is combined with across or shim
The animated join sets the output page height to the joined height divided by the image count, which only holds for a vertical strip with no spacing.
sharp([a, b], { join: { animated: true, across: 2 } }).gif()produces frames that are horizontal slices of the side-by-side pair, and a non-zeroshimbakes the spacer rows into every frame so the content drifts. When the division is not exact the page height written to the file is invalid and the output silently loses its animation.These combinations now fail input validation with a clear error; a plain animated join is unchanged. Regression tests added to test/unit/join.js.