Repository navigation
[pmp] MSB and LSB of PMP address now params - #2328
Merged
Merged
Conversation
marnovandermaas
marked this pull request as draft
November 5, 2025 17:53
marnovandermaas
force-pushed
the
pmp_lsb
branch
from
November 5, 2025 18:01
f4866cb to
89bc3ef
Compare
marnovandermaas
force-pushed
the
pmp_lsb
branch
2 times, most recently
from
November 13, 2025 10:54
db37403 to
7da4faf
Compare
Collaborator
Author
|
Keeping this PR as draft until I confirm the PMP pass rate is unchanged. |
Collaborator
Author
|
I've now run Ibex DV on this:
So now marking this as ready for review. |
marnovandermaas
marked this pull request as ready for review
November 19, 2025 14:38
SamuelRiedel
approved these changes
Nov 20, 2025
SamuelRiedel
left a comment
SamuelRiedel
left a comment
Contributor
There was a problem hiding this comment.
Thanks Marno. I have two small nits, but otherwise it looks good to me. I also ran a quick synthesis on your changes and it looks good.
Instead of hardcoding 33 and 2 all over the code base as the most significant and least significant bit of the PMP address, this change creates appropriate parameters in the Ibex package that can be re-used in the rest of the code base. This commit also replaces some hard-coded 16 values with PMP_MAX_REGIONS which was already a parameter in the Ibex package. I thought of adding a parameter for the least significant bit of the PMP address while analysing a question posed by Shutong Jin during the HACK@CHES'25 event.
Functionally pmp_mseccfg and pmp_mseccfg_q are the same when PMP is enabled. However, the RTL is a bit more clear if both the MML and RLB register are referenced through the pmp_mseccfg_q register name. I thought of this clarification while analysing a question posed by Shutong Jin during the HACK@CHES'25 event.
marnovandermaas
force-pushed
the
pmp_lsb
branch
from
November 20, 2025 16:45
7da4faf to
f73afc5
Compare
marnovandermaas
enabled auto-merge
November 20, 2025 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding 33 and 2 all over the code base as the most significant and least significant bit of the PMP address, this change creates appropriate parameters in the Ibex package that can be re-used in the rest of the code base.
This commit also replaces some hard-coded 16 values with PMP_MAX_REGIONS which was already a parameter in the Ibex package.
Finally it makes a slight clarifying change to avoid mixing pmp_mseccfg and pmp_mseccfg_q in the same assignment even though they refer to the same value.