Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4621.
Summary
Tests
.venv/bin/python python/tests/run.py— 982 passed, 58 skipped..venv/bin/python -m pytest python/tests/test_quantized.py -k qmm_affine_large_tiles -q— 90 subtests passed, covering exact and partial tiles across group sizes 32/64/128, 4/8 bits, and float32/float16/bfloat16..venv/bin/pre-commit run --all— passed.Benchmark
Apple M4 Max, bfloat16 activations, N = 12288, K = 4096, group size 64. Each value is the median of three process-level medians, with 20 measured calls after 3 warmups and alternating main/PR order. Main is
c69303b00f5f61860436e832f23fa8c34b96f93a.Reproduction script (run three times on main and this branch, alternating order):