Repository navigation
fbuffer: don't report failure for an empty write - #1210
Merged
Merged
Conversation
Contributor
|
Appveyor reported errors. |
fwrite() returns 0 when the size is 0, so msgpack_fbuffer_write() reported -1 for an empty buffer, and msgpack_pack_str_body() and msgpack_pack_object() failed on empty strings even though nothing went wrong. The C++ fbuffer got the same fix in msgpack#1165.
Author
|
Rebased onto c_master, thanks for fixing AppVeyor. |
b84330808
force-pushed
the
fix-fbuffer-empty-write
branch
from
November 15, 2026 04:16
31849d8 to
c8c925a
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## c_master #1210 +/- ##
============================================
+ Coverage 57.47% 62.66% +5.18%
============================================
Files 10 10
Lines 1124 1149 +25
Branches 129 141 +12
============================================
+ Hits 646 720 +74
+ Misses 478 429 -49 🚀 New features to boost your workflow:
|
Contributor
|
Thank you for updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fwrite()returns 0 when the size is 0, somsgpack_fbuffer_write()reported -1 for an empty buffer andmsgpack_pack_str_body()failed on empty strings to a FILE*, even though nothing went wrong. Same fix as #1165 for the C++ fbuffer, with a test.