Repository navigation
reject out-of-range timestamps when converting to time_point - #1211
Merged
Merged
Conversation
Contributor
|
Appveyor reported errors. |
rajath201
force-pushed
the
chrono-timestamp-overflow
branch
from
November 16, 2026 10:48
cd4998f to
a832770
Compare
Author
|
Rebased onto the latest cpp_master. No conflicts, and the patch itself is unchanged. |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1211 +/- ##
==============================================
- Coverage 85.36% 79.93% -5.44%
==============================================
Files 80 80
Lines 5099 5821 +722
Branches 507 635 +128
==============================================
+ Hits 4353 4653 +300
- Misses 746 1168 +422 🚀 New features to boost your workflow:
|
Contributor
|
@rajath201 , thank you for sending the PR. It looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
time_pointas/convert adaptors incpp11/chrono.hppaddstd::chrono::seconds(sec)from the wire straight onto the target time_point, so scaling seconds to the Duration's ticks is signed overflow whenever the decoded timestamp doesn't fit. A timestamp96 with tv_sec = INT64_MAX aborts under UBSan (9223372036854775807 * 1000000in<chrono>on libc++), the largest timestamp64 already overflows a nanosecond clock, and on a picosecond time_point any present-day timestamp32 does.Route the decode-side additions through
detail::checked_add, which range-checks both the scaling and the sum and throwsstd::overflow_error/std::underflow_error, the same exceptionsintegral_castalready raises in this adaptor. Floating-point reps keep the old path. The two new tests fail on the current tree and pass with the fix, and the full suite is green with-Werrorand UBSan.