Repository navigation
Closes #23666: Classify user management permissions as trusted in THREAT_MODEL.md - #23667
Merged
Merged
Conversation
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
November 10, 2026 21:17
jeremystretch
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #23666
Classifies holders of
users.add_userorusers.change_useras trusted actors inTHREAT_MODEL.md. Either permission lets a user assign groups, object permissions and superuser status, including to themselves, so they are effectively equivalent to superuser. The change adds a row to the trusted actors table, a matching row to the out-of-scope table, and a mention in the STRIDE elevation of privilege line.The permissions to manage groups and object permissions grant similar reach. I left them out to keep this to what #23666 covers, but I'm open to adding them here or in a follow-up.