Repository navigation
fix(reconciler): keep metadata source_match in the entity dedup hash - #601
Merged
Merged
Conversation
The dedup hash cleared all entity metadata, so a payload that addresses a different NetBox object through source_match.netbox_id merged into the prior ingestion log and was planned against the old object. Other metadata stays out of the hash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mfiedorowicz
requested review from
grant-nbl,
jajeffries,
leoparente,
manrodrigues and
samiura
as code owners
November 5, 2026 13:23
Vulnerability Scan: Passed — diode-authImage:
Commit: 68a9201 |
Vulnerability Scan: Passed — diode-reconcilerImage: No vulnerabilities found. Commit: 68a9201 |
Vulnerability Scan: Passed — diode-ingesterImage: No vulnerabilities found. Commit: 68a9201 |
|
Go test coverage
Total coverage: 57.8% |
jajeffries
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedup hash cleared all entity metadata. A payload that addresses a different NetBox object through
metadata.source_match.netbox_idgot the same hash as the prior payload, merged into its ingestion log, and was planned again against the old object. The new object never got a deviation.entityhashnow reduces eachmetadataStruct to itssource_matchentry (at every level) before hashing. All other metadata (run IDs, timestamps) stays out of the hash.Ops.CreateIngestionLogand the bulk ingest path. All fail without the fix.source_matchcreates one new ingestion log, because its hash changes.🤖 Generated with Claude Code