Repository navigation
Add default permissions to workflow files - #193
Merged
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
PR.yml loses its only explicit permissions declaration, leaving the configuration gap this PR aims to address.
1 open finding
What changed in this PR
Adds explicit default token permissions to GitHub Actions workflows to address CodeQL permission warnings.
Changes:
- Sets read-only contents permissions for CI, checks, tests, and publishing.
- Disables built-in token permissions for issue synchronization, which uses a separate token.
- Removes unnecessary write permissions from the PR workflow’s CI call.
| File | Description |
|---|---|
.github/workflows/sync_github_issues_to_azdo.yml |
Disables built-in token permissions and explains why. |
.github/workflows/run_unit_tests.yml |
Adds read-only contents permissions. |
.github/workflows/publish.yml |
Adds read-only default permissions. |
.github/workflows/PR.yml |
Removes CI caller permission overrides. |
.github/workflows/CI.yml |
Adds read-only contents permissions. |
.github/workflows/check_utilities.yml |
Adds read-only contents permissions. |
.github/workflows/check_ni_datastore.yml |
Adds read-only contents permissions. |
.github/workflows/check_examples.yml |
Adds read-only contents permissions. |
.github/workflows/check_docs.yml |
Adds read-only contents permissions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
marked this pull request as ready for review
October 15, 2026 16:24
dixonjoel
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
To resolve CodeQL items for this repo.
AB#4105720
What testing has been done?
Most of the workflows are tested as part of the PR checks. The publish workflow is virtually unchanged since it sets permissions in child jobs/steps. The Sync GitHub Issues workflow will be tested after submission by adding a comment to one of the existing github issues.