Repository navigation
Route configured remote requests through the built-in provider - #1934
oznetmaster merged 2 commits into
Conversation
|
Can you rebase on current main so we can see what changes are left? |
Base the remote-provider draft directly on current main, including the public provider API, ownership routing and TestAgentService rename. Keep explicit remote requests from falling back locally and evaluate runtime constraints at the selected backend. Preserve the already-tested final tree while removing superseded foundation commits and merge history from the review branch.
ebb5491 to
24d1a7c
Compare
|
@CharliePoole, the branch is now a single commit directly on current main ac7c28c, with the superseded foundation commits and merge history removed. The remaining diff contains only the configured remote-provider work, its tests and documentation. Its complete Git tree is identical to the previously tested, CI-passing head ebb5491; this update changes history and the description, not source bytes. The PR remains a draft. Prepared by Neil Colvin with assistance from OpenAI Codex. |
CharliePoole
left a comment
There was a problem hiding this comment.
Looks good. Thanks for clarifying.
|
@oznetmaster Would it be useful for us to create a long-running branch for the remote agent feature and merge your work periodically into it? |
|
@CharliePoole, yes, that would be useful. An upstream remote-feature branch would give us a shared integration point for small, reviewed changes while keeping unfinished functionality separate from main. We can regularly incorporate main and continue validating ordinary local execution alongside the remote cases. Would you like #1934 retargeted to that branch as the first contribution? Prepared by Neil Colvin with assistance from OpenAI Codex. |
|
Yes, lets use #1934. I don't think you can merge into a non-existent branch but you can create it from main first. No need for another review for that. |
Route explicitly configured remote requests through the built-in RemoteProcessAgentProvider. A package with no remote configuration keeps its normal local-process path; an invalid, unreachable or unsupported explicit remote request fails without local fallback.
The provider reads a bounded XML definition, qualifies advertised agent names, removes coordinator routing from forwarded packages and retains the originating client for each acquired proxy. Returning an agent uses that client even if its definition changes. A failed return retains ownership; a lost acquisition reply fences further allocation to that endpoint within the engine instance.
Runtime constraints are evaluated at the selected backend. Local leaves retain local availability checks, including within mixed packages. Explicitly remote unmanaged images are rejected before they can execute locally.
Current foundation
This refresh incorporates current main ac7c28c, including #1936's public provider contract, TestAgentService rename and coordinated API/agent dependencies: API 4.0.0-beta.101.2, Agent.Core 4.0.0-beta.6.2 and Extensibility/API 4.0.0-beta.6. The engine-local interface is not reintroduced. Five additional contract-identity tests from #1935 are retained here. Existing launcher/registration interfaces and wire command names stay unchanged.
The remote-provider changes were consolidated into commit 24d1a7c directly on main ac7c28c, with a Git tree identical to the previously tested and CI-passing head ebb5491. This PR now targets the upstream feature/remote-agents integration branch, created from main 437a8ec. The PR branch incorporates that base's README and workflow updates; no engine, Console or test source bytes changed in that update. CI is run on the resulting integration. The callback/task connection completion correction remains intact; it does not obtain or dispose a Task's borrowed AsyncWaitHandle. Its original Linux failure and the stress test that passed before the correction remain separate historical evidence.
Validation
Remaining scope
This initial feature-branch implementation supports literal loopback endpoints and a provisional #1922-derived protocol. Authenticated LAN/WAN transport and a stable definition schema remain future work. It does not stage files or translate remote-only paths. The test server already has access to the assemblies and is explicitly started/stopped by the harness; permanent server installation is not required by the architecture.
The Console still pre-checks global --framework availability locally. Backend-only project/API constraints work; the CLI path needs a separate frontend/API decision. Production authentication/transport, deployment/temporary servers, recovery, lifecycle deadlines, evidence/reservations/restoration and refreshed adapter/GUI/physical-backend validation remain separate follow-ups. Historical prototype coverage is not substituted for those checks.
Prepared by Neil Colvin with assistance from OpenAI Codex.