Skip to content

test(ALL): fix blockwise mode tests after Nightly changes - #2581

Merged
echasnovski merged 1 commit into
nvim-mini:mainfrom
abeldekat:test_surround
Oct 15, 2026
Merged

echasnovski merged 1 commit into
nvim-mini:mainfrom
abeldekat:test_surround

Conversation

@abeldekat

@abeldekat abeldekat commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Details:

  • See PR 42321 in neovim/neovim

That PR also breaks a test in mini.align: "Align with preview | works | test + args { "Normal-block" }"

I don't know if the fix needs to be in align, or in test_align. New output:

  --|---------|---------|---------|
  01|  a-_-b-_-c                   
  02|aaa-_-bbb_ccc                 

The old output also aligns on the underscore before the c character:

  --|---------|---------|---------|
  01|  a-_-b-_c                    
  02|aaa-_bbb_ccc                  

I manually replayed that test with version 0.12.6, and was surprised to see that I could not reproduce the old alignment from the screenshot. The result is always according to the new output...

@echasnovski

Copy link
Copy Markdown
Member

I am not quite sure, but it feels like something got subtly broken in after that PR. In a sense that the new behavior is not something that matches the documentation.

As per the test adjustment, I'd rather adjust the position of the target mark instead of the resulting lines. With short comment about why it has to be different on Neovim<0.13 and Neovim>=0.13.

In test_surround.lua it is for where a mark is done: set_cursor(2, child.fn.has('nvim-0.13') == 1 and 2 or 3).

In test_align.lua (which seems to have the same cause of not the expected) it is through different mark, as mark a is
used for other parameters: child.fn.setpos("'b", { 0, 2, 4, 0 }).

I manually replayed that test with version 0.12.6, and was surprised to see that I could not reproduce the old alignment from the screenshot. The result is always according to the new output...

I can reproduce it in 0.12.6 as described in the test, so there is okay.

@abeldekat
abeldekat force-pushed the test_surround branch 2 times, most recently from f2e82e0 to 0141937 Compare October 14, 2026 18:49
@abeldekat abeldekat changed the title test(surround): fix blockwise mode test after Nightly changes test(all): fix blockwise mode test after Nightly changes Oct 14, 2026
@abeldekat abeldekat changed the title test(all): fix blockwise mode test after Nightly changes test(ALL): fix blockwise mode tests after Nightly changes Oct 14, 2026
@abeldekat
abeldekat requested a review from echasnovski October 14, 2026 19:14
Details:
- See PR 42321 in neovim/neovim

@echasnovski echasnovski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

@echasnovski
echasnovski merged commit db1e8b3 into nvim-mini:main Oct 15, 2026
12 checks passed
@abeldekat
abeldekat deleted the test_surround branch October 15, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants