Repository navigation
Conversation
|
@yegor256, please take a look when you have a moment. |
2520e98 to
bd49d02
Compare
|
@morphqdd this changes how Maven output is piped and parsed to show the running goal in the progress line. It looks more like an enhancement than a bug fix, so I am not merging it and am passing it to the maintainer for review. Generated by Claude Code |
|
@morphqdd CI is green, but this adds a new feature (the running Maven goal in the progress line) and changes how Maven stdout is piped. I do not merge features, so I left it assigned to @yegor256 for manual review. Written by Claude Code Opus 5.5 Generated by Claude Code |
yegor256
left a comment
There was a problem hiding this comment.
src/mvnw.js:174 now calls readline.createInterface, but test/test_mvnw_concurrent.js still supplies a readline mock without that method or a child stdout stream. The macOS build fails twice with TypeError: readline.createInterface is not a function. Extend the process/stream fixtures and test actual goal-line delivery and output forwarding, beyond the regex helper. Also gate the new piped-output branch on stdout.isTTY so redirected runs do not receive cursor-control sequences.
# Conflicts: # test/test_mvnw.js
…hild stdout, and test the goal line and the forwarded output
|
Rebased on master. The piped-output branch now runs only when |
The progress line now names the Maven goal that is running:
To get the goal, Maven runs without
--quietwhile the ticker is on, and its stdout is read line by line.[INFO],[WARNING]and[DEBUG]lines are dropped, as--quietdid before, everything else (errors, program output) is still printed.--batchand--verboseruns are not changed.Closes #1257