Skip to content

#1257: show the running Maven goal in the progress line - #1456

Open
morphqdd wants to merge 2 commits into
objectionary:masterfrom
morphqdd:1257
Open

morphqdd wants to merge 2 commits into
objectionary:masterfrom
morphqdd:1257

Conversation

@morphqdd

@morphqdd morphqdd commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

The progress line now names the Maven goal that is running:

[10 steps: eo:assemble] 6s; 264 files generated so far...
[10 steps: eo:lint] 8s; 414 files generated so far...
[10 steps: compiler:compile] 12s; 1235 files generated so far...

To get the goal, Maven runs without --quiet while the ticker is on, and its stdout is read line by line. [INFO], [WARNING] and [DEBUG] lines are dropped, as --quiet did before, everything else (errors, program output) is still printed. --batch and --verbose runs are not changed.

Closes #1257

@morphqdd

morphqdd commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@yegor256, please take a look when you have a moment.

@morphqdd
morphqdd force-pushed the 1257 branch 2 times, most recently from 2520e98 to bd49d02 Compare October 12, 2026 10:54

Copy link
Copy Markdown
Member

@morphqdd this changes how Maven output is piped and parsed to show the running goal in the progress line. It looks more like an enhancement than a bug fix, so I am not merging it and am passing it to the maintainer for review.


Generated by Claude Code

@yegor256 yegor256 self-assigned this Oct 12, 2026

Copy link
Copy Markdown
Member

@morphqdd CI is green, but this adds a new feature (the running Maven goal in the progress line) and changes how Maven stdout is piped. I do not merge features, so I left it assigned to @yegor256 for manual review.

Written by Claude Code Opus 5.5


Generated by Claude Code

@yegor256 yegor256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/mvnw.js:174 now calls readline.createInterface, but test/test_mvnw_concurrent.js still supplies a readline mock without that method or a child stdout stream. The macOS build fails twice with TypeError: readline.createInterface is not a function. Extend the process/stream fixtures and test actual goal-line delivery and output forwarding, beyond the regex helper. Also gate the new piped-output branch on stdout.isTTY so redirected runs do not receive cursor-control sequences.

…hild stdout, and test the goal line and the forwarded output
@morphqdd

morphqdd commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on master. The piped-output branch now runs only when ticking is true, which needs process.stdout.isTTY, so redirected runs get no cursor control. The test wrapper now gives readline.createInterface and a child stdout, and two new tests check that a goal line shows up in the progress line and that a non-INFO line of Maven is forwarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eoc dataize command provides insufficient progress updates during prolonged compilation

2 participants