Skip to content

DMN17-197/DMN17-198 Replace example diagrams with SVGs where possible - #49

Merged
falko merged 3 commits into
omg-dmn-taskforce:masterfrom
SimonRinguette:example-diagrams
Jun 2, 2026
Merged

falko merged 3 commits into
omg-dmn-taskforce:masterfrom
SimonRinguette:example-diagrams

Conversation

@SimonRinguette

Copy link
Copy Markdown
Contributor

As requested by @falko here are the diagrams in SVG format for the examples.

@SimonRinguette
SimonRinguette requested a review from falko June 2, 2026 02:42

@falko falko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonRinguette thank you very much! These look much better. I do have a couple of findings that would be nice to change but nothing really blocking.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonRinguette could you please remove the Trisotech logo?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The decision service divider line touches the decision. Also all elements now have Services. as a prefix. Is that because they are imported? Is this just an updated visualization of what is already in the example XML or did this get modified since last time you exported it to the spec?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position can be an issue on our side I can fix it manually.

For the prefix, it could be that the image was taken from the imported model instead of the main model?

If you ware talking about Figure 11-41, it is definitly the depiction from the imported model.

Page 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some icons changed but this seems to be rather a correction that boxed expressions have a different icon than decision tables. In DMN 1.8, we should finally standardize the icons.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels of Application risk score model and Risk management strategy are overflowing a little too much compared to the PNG version. Is there a chance to increase the shape size a little or add a line break?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is what is in the model, i can modify the font (Loan default data has a smaller font) but the model as is renders like that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label Credit contingency factor table would better be spread across the lines as in the PNG.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also need to modify the model

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again some labels colliding with their icons. But I know that is a hard thing to solve in SVG.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to modify the model slightly for that.

@falko falko changed the title Added SVG diagrams renderings DMN17-197/DMN17-198 Replace example diagrams with SVGs where possible Jun 2, 2026
@falko
falko merged commit 368a8de into omg-dmn-taskforce:master Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants