Repository navigation
DMN17-197/DMN17-198 Replace example diagrams with SVGs where possible - #49
Conversation
falko
left a comment
There was a problem hiding this comment.
@SimonRinguette thank you very much! These look much better. I do have a couple of findings that would be nice to change but nothing really blocking.
There was a problem hiding this comment.
@SimonRinguette could you please remove the Trisotech logo?
There was a problem hiding this comment.
The decision service divider line touches the decision. Also all elements now have Services. as a prefix. Is that because they are imported? Is this just an updated visualization of what is already in the example XML or did this get modified since last time you exported it to the spec?
There was a problem hiding this comment.
There was a problem hiding this comment.
Some icons changed but this seems to be rather a correction that boxed expressions have a different icon than decision tables. In DMN 1.8, we should finally standardize the icons.
There was a problem hiding this comment.
The labels of Application risk score model and Risk management strategy are overflowing a little too much compared to the PNG version. Is there a chance to increase the shape size a little or add a line break?
There was a problem hiding this comment.
I believe this is what is in the model, i can modify the font (Loan default data has a smaller font) but the model as is renders like that.
There was a problem hiding this comment.
The label Credit contingency factor table would better be spread across the lines as in the PNG.
There was a problem hiding this comment.
Would also need to modify the model
There was a problem hiding this comment.
Again some labels colliding with their icons. But I know that is a hard thing to solve in SVG.
There was a problem hiding this comment.
Need to modify the model slightly for that.
…. Fixed the resolution on Loan Products.png
As requested by @falko here are the diagrams in SVG format for the examples.