Repository navigation
Conversation
…dicator Slot takes swiftStyle and onNativeSDKEvent so listRowInsets and listRowBackground reach a hosted row. Sheet content ignores the bottom container safe area. Form swiftStyle was already on main. Validation: iOS simulator proof in tests/native-features fixture one-native-form-slot-style: Form top contentMargins 0 and listSectionSpacing 40 apply, Slot listRowInsets leading 64 and background shift the hosted row, large-detent sheet bottom bar reaches the screen bottom edge. bun run generate reproduces the committed generated files. Team-Machine-Session: m50986
Validation: vitest tests/nativeDocs.test.ts passes (379 tests). Team-Machine-Session: m50986
Validation: iOS simulator build of this source; List and ScrollView in a large sheet at max scroll end above the home indicator, Form unchanged. Team-Machine-Session: m50986
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One.iOS.SlottakesswiftStyleandonNativeSDKEvent, solistRowInsets,listRowBackgroundand the other row modifiers reach a hosted React Native row. PresentedSheetcontent ignores the bottom container safe area, so a full-height Form or List reaches the screen bottom while SwiftUI scroll views keep their own inset.Formalready hadswiftStyleon main.Changes are in
codegen/emitContainers.ts,codegen/emitSheet.ts, the hand-written Slot view, and the regenerated specs, types and Sheet file. Proof fixture:tests/native-features/fixtures/one-native-form-slot-style.tsx.Validation: iOS simulator proof with that fixture. Form top contentMargins 0 and listSectionSpacing 40 apply, Slot listRowInsets leading 64 and background shift the hosted row, and a large-detent sheet bottom bar reaches the screen bottom edge.
bun run generatereproduces the committed generated files. No Android, no automated tests, no before screenshot of the sheet baseline.