Repository navigation
Retain notification service state on Android fixture failure - #1006
Merged
Merged
Conversation
The notification warm-tap failure retained an empty shade while logcat recorded its notification being enqueued. Keep notification-manager and SystemUI service dumps with the existing failure artifact to distinguish platform filtering from missing app posts. No assertion, timeout, retry or runtime change. Validation: actionlint; actual service dumps produced by API37 investigation39708502006; unchanged originalAPK proof39709205918 passed179 checks, which is not a repair claim. Team-Machine-Session: r110538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android fixture failures retain the UI hierarchy and logcat, but those cannot distinguish a notification that was never posted from one filtered out by SystemUI. Main run 39702110479 illustrates the gap:
n3-1was enqueued and grouped, while the captured shade was empty.Keep the notification-manager and SystemUI service dumps with the existing failure artifact. This adds two best-effort diagnostic commands after a failed suite. Assertions, timeouts, retries and library runtime are unchanged.
Validation:
actionlint .github/workflows/test-native-android.ymlandgit diff --checkpass. API 37 investigation 39708502006 produced both service dumps. The original APK and unchanged proof assertions passed all 179 checks in investigation 39709205918, including notification warm/cold responses and suppression controls. That passing run does not establish a repair of the intermittent notification failure; its cause remains open.The separate investigation branch and workflow reductions are excluded from this PR.