Skip to content

feat(api): add response error diagnostics and model notices - #2948

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-304
Oct 15, 2026
Merged

feat(api): add response error diagnostics and model notices#2948
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-304

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Expose optional response error diagnostics and add model shutdown notices.

Changes

  • Expose the original error type and associated request parameter on response errors.
  • Add shutdown notices for seven model identifiers while preserving the identifiers.

@jbeckwith-oai
feat(api): add response error diagnostics and model notices
1aa8819 
Castiron-Internal-PR: openai/openai-node-internal#304
Castiron-Source-SHA: ee0e019237ceeef943eda735c9316a2e77329137
Castiron-Public-Base-SHA: 5f218bf
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 5f218bf5d8770de5445012b4f1c3b150db983379.

✅ No new custom-code files detected.

51 mixed files remain; 0 existing customizations changed; 2 generated baselines changed.

Compared 5f218bf5d877 → 1aa88194933c. Generated baselines verified.

File Result Current custom patch
src/resources/beta/responses/responses.ts Generated baseline changed +12 / −0
src/resources/responses/responses.ts Generated baseline changed +166 / −49
49 existing customizations unchanged
  • api.md
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/client.ts
  • src/resources/admin/organization/usage.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/ws-base.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws-base.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws-base.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws-base.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/ws-base.ts
  • src/resources/responses/ws.ts

9 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38688180561 --repo openai/openai-node \
  --name castiron-custom-code-38688180561-1 --dir /tmp/castiron-custom-code-38688180561-1
git apply --stat /tmp/castiron-custom-code-38688180561-1/custom-code.patch
cat /tmp/castiron-custom-code-38688180561-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 5f218bf5d8770de5445012b4f1c3b150db983379 1aa88194933c4836db8a30680fec894221eac399
python3 scripts/castiron/custom_code_report.py report \
  --base 5f218bf5d8770de5445012b4f1c3b150db983379 \
  --head 1aa88194933c4836db8a30680fec894221eac399 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-1aa88194933c
cat /tmp/castiron-custom-code-1aa88194933c/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 15, 2026 05:41
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 15, 2026 05:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T05:44:18.795368Z 1aa8819 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-15T05:44:57.644063Z 1aa8819 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.675s for Node SDK PR #2948.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 177ms
tests/chat-completions-create.test.ts ✅ Passed 236ms
tests/chat-completions-stream.test.ts ✅ Passed 137ms
tests/files-content-binary.test.ts ✅ Passed 198ms
tests/files-create-multipart.test.ts ✅ Passed 242ms
tests/files-list-pagination.test.ts ✅ Passed 142ms
tests/initialize-config.test.ts ✅ Passed 155ms
tests/instance-isolation.test.ts ✅ Passed 202ms
tests/models-list.test.ts ✅ Passed 202ms
tests/responses-background-lifecycle.test.ts ✅ Passed 176ms
tests/responses-body-method-errors.test.ts ✅ Passed 303ms
tests/responses-cancel-timeout.test.ts ✅ Passed 227ms
tests/responses-cancel.test.ts ✅ Passed 299ms
tests/responses-compact-retries.test.ts ✅ Passed 304ms
tests/responses-compact.test.ts ✅ Passed 182ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 172ms
tests/responses-create-advanced.test.ts ✅ Passed 181ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.067s
tests/responses-create-errors.test.ts ✅ Passed 186ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 179ms
tests/responses-create-retries.test.ts ✅ Passed 227ms
tests/responses-create-stream-failures.test.ts ✅ Passed 122ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.166s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.279s
tests/responses-create-stream.test.ts ✅ Passed 114ms
tests/responses-create-terminal-states.test.ts ✅ Passed 234ms
tests/responses-create-timeout.test.ts ✅ Passed 251ms
tests/responses-create.test.ts ✅ Passed 193ms
tests/responses-delete.test.ts ✅ Passed 229ms
tests/responses-input-items-errors.test.ts ✅ Passed 214ms
tests/responses-input-items-list.test.ts ✅ Passed 220ms
tests/responses-input-items-options.test.ts ✅ Passed 152ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 288ms
tests/responses-input-tokens-count.test.ts ✅ Passed 229ms
tests/responses-malformed-inputs.test.ts ✅ Passed 901ms
tests/responses-not-found-errors.test.ts ✅ Passed 248ms
tests/responses-parse.test.ts ✅ Passed 161ms
tests/responses-retrieve-retries.test.ts ✅ Passed 236ms
tests/responses-retrieve.test.ts ✅ Passed 222ms
tests/responses-stored-method-errors.test.ts ✅ Passed 369ms
tests/retry-behavior.test.ts ✅ Passed 3.133s
tests/sdk-error-shape.test.ts ✅ Passed 284ms

View OkTest run #38688151523

SDK merge (907d702a672f) · head (1aa88194933c) · base (5f218bf5d877) · OkTest (63b471b22245)

markstuart-oai
markstuart-oai approved these changes Oct 15, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated source review of 1aa88194933c4836db8a30680fec894221eac399: no blocking findings.

The stable Responses, beta Responses, and video error types expose optional, nullable type and param fields while preserving code and message. The model notices keep the existing identifiers available. The new transport test covers all three APIs and distinguishes populated, null, and omitted diagnostics. The change adds no runtime parser or compatibility wrapper.

Verified hosted checks on this head passed: lint, build, Windows build, Node 22/24/26 tests, ecosystem tests, and Castiron baseline and budget checks. I reviewed the source and tests without running local project workloads.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 4fd22b0 Oct 15, 2026
63 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-304 branch October 15, 2026 06:07
@openai-sdks openai-sdks Bot mentioned this pull request Oct 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai