[SeqLaz]

Simplifies the cloud project creation dialog in QFieldSync by removing the option "Convert currently open project to cloud project (recommended)" conversion option, defaulting to direct QFieldCloud project creation, and introducing a dedicated project compatibility step using ProjectChecker.

Note that the file qfieldsync/core/cloud_converter.py was removed (requested by linter)

untitled.webm

[duke-nyuki]

Task linked: QF-6460 Remove the two radio buttons when creating a new QFieldCloud project

[gounux]

@SeqLaz could you fix the conflict ? 🦾

[suricactus]

@nirvn whenever you can review this, please go ahead :)

[SeqLaz]

@SeqLaz could you fix the conflict ? 🦾

Yes, I'm currently waiting this PR: #821 to be merged, as there will introduce more conflicts, so I will work on it! 🦾

[SeqLaz]

@gounux All is on green lights! 🦾

Just a review from your side will be good!

[suricactus]

Let's wait for @nirvn review here, no need to hurry on this one. One review is enough ;)

[nirvn]

@SeqLaz , looking at this now. One generic comment: please do not merge different objectives / changes into a single commit. You smashed the removal of cloudify and the addition of the project checker into one commit. When people will git log (or git blame) in the future, it'll be misleading.

[nirvn]

@SeqLaz , would it be possible to remove the project checker change out of this PR into a separate one?

[SeqLaz]

@SeqLaz , looking at this now. One generic comment: please do not merge different objectives / changes into a single commit. You smashed the removal of cloudify and the addition of the project checker into one commit. When people will git log (or git blame) in the future, it'll be misleading.

@SeqLaz , would it be possible to remove the project checker change out of this PR into a separate one?

Many thanks @nirvn 🥷!!!
I will close this PR and create two new PRs well structured! 🦾

[suricactus]

Not sure why we need to close the PR, since you can force push the correct commits only here. In any case, better delete the branch afterwards.

[SeqLaz]

@nirvn @suricactus @gounux in this PR #840 is only the part of removing the cloudify option!

After is merged, I will create a new PR with the integration of the project checker step before enter the project details