Skip to content

Fix folder picker opening twice on first cloud synchronization #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristan0x wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix folder picker opening twice on first cloud synchronization #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11dfc8f
fix: connect the local directory button only once in the transfer dialog
tristan0x Oct 12, 2026
450b2f2
fix: keep the current directory when the folder picker is cancelled
tristan0x Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions qfieldsync/gui/cloud_transfer_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ def __init__(
self.preferNoneButton.clicked.connect(self._on_prefer_none_button_clicked)
self.preferLocalButton.clicked.connect(self._on_prefer_local_button_clicked)
self.preferCloudButton.clicked.connect(self._on_prefer_cloud_button_clicked)
# connect once here and not in `showEvent`, which is emitted on every `show()`/`open()`
self.localDirectoryButton.clicked.connect(
make_folder_selector(self.localDirectoryLineEdit)
)

self.localDirOpenButton.clicked.connect(
lambda: self.on_local_dir_open_button_clicked()
Expand Down Expand Up @@ -257,9 +261,6 @@ def show_project_local_dir_selection(self):
self.localDirectoryLineEdit.setText(
QDir.toNativeSeparators(str(get_unique_empty_dirname(export_dirname)))
)
self.localDirectoryButton.clicked.connect(
make_folder_selector(self.localDirectoryLineEdit)
)

def show_project_compatibility_page(self):
if not self.is_project_compatible_page_prepared:
Expand Down
19 changes: 15 additions & 4 deletions qfieldsync/utils/qt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,30 @@
from typing import Callable, Optional

from qgis.PyQt import QtWidgets
from qgis.PyQt.QtCore import QRectF, QSize, Qt
from qgis.PyQt.QtCore import QCoreApplication, QRectF, QSize, Qt
from qgis.PyQt.QtGui import QIcon, QPainter, QPainterPath, QPixmap, QTextDocument
from qgis.PyQt.QtSvg import QSvgRenderer
from qgis.PyQt.QtWidgets import QTreeWidgetItem

from .file_utils import DirectoryTreeDict, DirectoryTreeType


def select_folder(line_edit_widget):
line_edit_widget.setText(
QtWidgets.QFileDialog.getExistingDirectory(directory=line_edit_widget.text())
def select_folder(line_edit_widget: QtWidgets.QLineEdit) -> None:
"""
Open a folder picker and store the chosen directory in `line_edit_widget`.

The line edit is left untouched when the user cancels the picker.
"""
parent = line_edit_widget.window()
directory = QtWidgets.QFileDialog.getExistingDirectory(
parent,
QCoreApplication.translate("QFieldSync", "Select directory"),
line_edit_widget.text(),
)

if directory:
line_edit_widget.setText(directory)


def make_folder_selector(widget):
return partial(select_folder, line_edit_widget=widget)
Expand Down
Loading