Repository navigation
fix: FC43 trace, reload between requests, bounded shutdown, control API checks and input validation (v1.6.0) - #25
Merged
Merged
Conversation
…PI checks and input validation (v1.6.0) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the policy 1.6 review of modbus-simulator. The behaviour changes are listed under
### Breakingin RELEASE.md (v1.6.0), each with how to restore the old behaviour.What changes:
ok: false,illegal_data_address, as the client receives it. Identity values are limited to 244 bytes (UTF-8), the most one response carries, in the schema and in semantic validation.runshuts down within 10 s (control API, then the Modbus server, one bound), waits for the control API goroutine, and exits with code 4 when requests are still in progress. A second SIGINT or SIGTERM ends the process./healthzanswers 503 with the error.Originheader (403) and closes idle keep-alive connections after 30 s.float32codec value beyond the float32 range is refused; an environment variable that does not parse is a usage error (exit 2) naming it; an expectation matcher may name only trace fields (exit 3 otherwise).internal/leakcheck) runs after the tests ofinternal/simulatorandcmd;make fuzzdiscovers its targets; CI regenerates the codec examples and fails on a difference (make generate-check, jobGenerated codec examples).Files:
internal/simulator/{handler,store,server,control,validate,codecfield}.go,schemas/{fixture,expect}-v1.json,cmd/{root,run}.go,internal/leakcheck/, tests ininternal/simulatorandcmd,Makefile,.github/workflows/ci.yml, README.md, REQUIREMENTS.md, ARCHITECTURE.md, SECURITY.md, TESTING.md, RELEASE.md.Tests: new regression tests for every change, each shown to fail with its fix removed; the concurrency and shutdown tests pass with
-race -count=20;make check,make soak,make fuzzandmake generate-checkpass; otfabric-policy is compliant.Checks
make check(vet, golangci-lint, govulncheck, the race tests, coverage),make soak(2 min),make fuzz(30 s, three targets) andmake generate-checkpass; the policy checker is compliant.🤖 Generated with Claude Code