Repository navigation
fix: cement trade too high in some regions - #88
Merged
Merged
Conversation
…mfa into development/fix-cement-trade
fbenke-pik
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes historical cement trade that was too high (e.g. 1880–1900) in regions containing countries without cement production.
Previously, the backcasting reference mixed units (tonnes of production, USD of GDP for countries without production, tonnes of trade for the US). When aggregated, GDP dominated the regional reference (e.g. ~99.7 % in EUR and NEU, coming from small territories like MLT or GIB). This affected both the backcast and the 2024–2025 forecast.
Changes:
Effect: 1995–2023 unchanged. H12 trade before 1995 is lower in regions with countries without production; 2024–2025 forecasts change by up to ±15 % (e.g. EUR imports). At ISO level, mainly small countries without production are affected.