Repository navigation
feat: write the time horizon of each model to a time_range file - #92
Merged
Merged
Conversation
…cCoScalars Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks
tobiasdiez
approved these changes
Nov 12, 2026
tobiasdiez
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Can we also reuse the calcCoScalars function for the "legacy" parameters in the gitlab repo?
Collaborator
Author
|
Yes, we can, but only without additional overhead if we hard-code the values in fullMFA... Best location would be inst/extdata, then we need a reader, then we need another calc function :-D |
bennet21
approved these changes
Nov 13, 2026
Contributor
Okay, never mind. Why does it need to be so complicated to add a few parameters :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fullMFA now writes the time horizon of each model to
st_time_range.cs4r,ce_time_range.cs4randpl_time_range.cs4r, so that remind-mfa can take it from the input data instead of its own config:The new
calcCoScalarswrites any named numeric vector in this form (onename,valueline per scalar), so further scalars can be passed the same way.🤖 Generated with Claude Code