Skip to content

feat: write the time horizon of each model to a time_range file - #92

Merged
JakobBD merged 2 commits into
pik-piam:mainfrom
JakobBD:write_years
Nov 12, 2026
Merged

JakobBD merged 2 commits into
pik-piam:mainfrom
JakobBD:write_years

Conversation

@JakobBD

@JakobBD JakobBD commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

fullMFA now writes the time horizon of each model to st_time_range.cs4r, ce_time_range.cs4r and pl_time_range.cs4r, so that remind-mfa can take it from the input data instead of its own config:

start_historical,1900
end_historical,2022
end_future,2150

The new calcCoScalars writes any named numeric vector in this form (one name,value line per scalar), so further scalars can be passed the same way.

🤖 Generated with Claude Code

JakobBD and others added 2 commits November 12, 2026 11:57
…cCoScalars

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we also reuse the calcCoScalars function for the "legacy" parameters in the gitlab repo?

@JakobBD

JakobBD commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

Yes, we can, but only without additional overhead if we hard-code the values in fullMFA...

Best location would be inst/extdata, then we need a reader, then we need another calc function :-D

@JakobBD
JakobBD merged commit ed753c3 into pik-piam:main Nov 12, 2026
1 check passed
@tobiasdiez

Copy link
Copy Markdown
Contributor

Yes, we can, but only without additional overhead if we hard-code the values in fullMFA...

Best location would be inst/extdata, then we need a reader, then we need another calc function :-D

Okay, never mind. Why does it need to be so complicated to add a few parameters :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants