Skip to content

translate 'unitless' to empty string in submission - #568

Merged
fbenke-pik merged 2 commits into
pik-piam:masterfrom
fbenke-pik:master
Oct 8, 2026
Merged

fbenke-pik merged 2 commits into
pik-piam:masterfrom
fbenke-pik:master

Conversation

@fbenke-pik

Copy link
Copy Markdown
Collaborator

Purpose of this PR

unitless is used to avoid forgetting units, but is not accepted in some projects, which actually expect an empty unit.
This PR always converts unitless in the generated submission to an empty unit.

Checklist:

  • I did not use Excel to open csv files or checked that no side-effects occur (changed values, many new quotation marks, …)
  • I added any renamed piam_variable to renamed_piam_variables.csv to guarantee backwards compatibility.
  • For REMIND variables, I used |+| notation consistently. This can be achieved automatically with updatePlusUnit().

It is recommended to have a look at the tutorial before submission.

@fbenke-pik
fbenke-pik requested a review from merfort October 8, 2026 15:13

@merfort merfort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Falk!

@merfort

merfort commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@gabriel-abrahao and @flohump FYI: common definitions does not except "unitless", but enforces an empty unit cell. This is what Daniel wrote to me:

About „unitless“, this was an issue in the legacy database and a custom solution for some projects. For all submissions using the new infrastructure (i.e., ixmp4) and the new apps, please leave an empty cell in the unit column. This is consistent with an empty line in the relevant definition, see e.g. https://github.com/IAMconsortium/common-definitions/blob/22efedc13e2e459a1774d4a84e781ed028a2d639/definitions/variable/sdg-indicators/sdg.yaml#L156

@fbenke-pik
fbenke-pik merged commit e5b02a7 into pik-piam:master Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants