Repository navigation
translate 'unitless' to empty string in submission - #568
Merged
Merged
Conversation
Contributor
|
@gabriel-abrahao and @flohump FYI: common definitions does not except "unitless", but enforces an empty unit cell. This is what Daniel wrote to me:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
unitlessis used to avoid forgetting units, but is not accepted in some projects, which actually expect an empty unit.This PR always converts
unitlessin the generated submission to an empty unit.Checklist:
renamed_piam_variables.csvto guarantee backwards compatibility.|+|notation consistently. This can be achieved automatically withupdatePlusUnit().It is recommended to have a look at the tutorial before submission.