Repository navigation
mod_mam_mnesia: reduce paged query memory usage - #4636
Merged
Merged
Conversation
Member
|
Hi, nice improvement! There's a recent merged commit that also involves mod_mam_mnesia.erl, and there's a source code conflict. Do you have spare time to resolve the conflict? If not, I can take a look. |
Contributor
Author
|
Sure, will do it in an hour. |
Reduce retained memory for paginated archive queries; preserve query filters, ordering, page limits, counts and completeness, including records with equal archive IDs. Support count only queries without message retrieval or conversion; preserve existing behavior for unlimited queries. Concurrent archive deletions can shorten a returned page. Add regression coverage for pagination, filters, equal archive IDs, count only requests and XML-heavy queries under a heap limit. OTP 28.5.0.8 references: [1] https://github.com/erlang/otp/blob/OTP-28.5.0.8/lib/stdlib/src/dets.erl#L1755-L1764 [2] https://github.com/erlang/otp/blob/OTP-28.5.0.8/lib/stdlib/src/dets.erl#L2958-L2987
catap
force-pushed
the
mnesia-paginate
branch
from
October 28, 2026 21:55
45e30cf to
d1a0f02
Compare
Contributor
Author
|
@badlop here it is. I had rebased to the last master and included one more commit which extracts only timestamp, without payload. I can open it as separated PR, but I think this is related to current one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce retained memory for paginated archive queries; preserve query filters, ordering, page limits, counts and completeness, including records with equal archive IDs.
Support count only queries without message retrieval or conversion; preserve existing behavior for unlimited queries. Concurrent archive deletions can shorten a returned page.
Add regression coverage for pagination, filters, equal archive IDs, count only requests and XML-heavy queries under a heap limit.
OTP 28.5.0.8 references:
[1] https://github.com/erlang/otp/blob/OTP-28.5.0.8/lib/stdlib/src/dets.erl#L1755-L1764
[2] https://github.com/erlang/otp/blob/OTP-28.5.0.8/lib/stdlib/src/dets.erl#L2958-L2987