Repository navigation
Fail loudly when existing manifest entries cannot be read - #807
Open
thomashoneyman wants to merge 1 commit into
Open
thomashoneyman wants to merge 1 commit into
thomashoneyman wants to merge 1 commit into
Conversation
thomashoneyman
force-pushed
the
fix/manifest-index-read-errors
branch
from
October 14, 2026 19:32
07a3b70 to
2893d8b
Compare
f-f
reviewed
Oct 14, 2026
thomashoneyman
force-pushed
the
fix/manifest-index-read-errors
branch
from
October 14, 2026 20:10
2893d8b to
ae16d87
Compare
f-f
force-pushed
the
fix/manifest-index-read-errors
branch
from
October 18, 2026 23:05
ae16d87 to
af39b17
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that inserting a manifest treats a failure to parse the existing entry as if the file were empty. This can discard previously published versions when adding a new one. I noticed this specifically in the
harmoniapackage, where it had (somehow) at some point had a description that was too long, which got deleted in an update due to this bug, but since we've since then upped the description limit it was possible for me to restore 0.1.0 as-is to the registry index. (It was fully published everywhere, it was just missing in the metadata).At the root,
readEntryFiledidn't distinguish a missing entry from an invalid one, but now it does:Right Nothing: no entry exists.Right (Just manifests): the entry was read and parsed.Left error: reading or parsing failed, with the entry path included.This does break
readEntryFilewhich is consumed by Spago insrc/Spago/Registry.pursin thegetManifestFromIndexImplfunction, so when that pin updates it would have to be updated. The current pin is OK.