Repository navigation
SVG: apply the letter-spacing of text - #2204
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The labels of spaCy's displaCy dependency diagrams use
letter-spacing: 2px, and Inkscape writesletter-spacingon every text. fpdf2 ignores it, so spaced text is drawn tight.The
letter-spacingof a<text>or<tspan>is now applied with the PDF character spacing operator (Tc), reset after each run. It is inherited, em and ex are relative to the font size, andnormalor an unreadable value means no spacing. The spacing is also added to the run widths, sotext-anchor="middle"and"end"stay correct.TextRungets aletter_spacingfield, defaulting to 0.test_svg_text_letter_spacingandtest_svg_text_letter_spacing_bounding_boxcover these; the spacing cases fail without the change.