Repository navigation
SVG: clip away an element whose clipPath is empty - #2205
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An element whose
clip-pathreferences a<clipPath>that yields no shape (no children, or only a<g>or<switch>, which can't be part of a clipping path) fails withKeyError: '#clip1', as in several files of the resvg test suite. So does aclip-paththat references an id that isn't a<clipPath>.An empty clipping path now clips the whole element away, as the SVG specification says. A reference to something that isn't a
<clipPath>is ignored with a warning, and the element is drawn without clipping, as in browsers. Nothing changes for clip paths that do have a shape, or in what gets registered.test_svg_empty_clip_pathandtest_svg_clip_path_reference_to_nothingcover these; they fail without the change.